[env] add project filter to ls command #382
Merged
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyeh
approved these changes
Sep 10, 2024
cmd/esc/cli/env_ls.go
Outdated
| @@ -56,11 +59,13 @@ func newEnvLsCmd(env *envCommand) *cobra.Command { | |||
|
|
|||
| cmd.PersistentFlags().StringVarP( | |||
| &orgFilter, "organization", "o", "", "Filter returned stacks to those in a specific organization") | |||
| cmd.PersistentFlags().StringVarP( | |||
| &projectFilter, "project", "p", "", "Filter returned stacks to those in a specific project") | |||
There was a problem hiding this comment.
I know this is just copy from the line above, but this really should be environments instead of stacks right? (it's probably copypasta from pulumi/pulumi)
seanyeh
pushed a commit
that referenced
this pull request
Sep 10, 2024
* [env] add project filter to ls command * update changelog with PR # * resolve merge issues * s/stacks/environments/
seanyeh
pushed a commit
that referenced
this pull request
Sep 10, 2024
* [env] add project filter to ls command * update changelog with PR # * resolve merge issues * s/stacks/environments/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ esc env ls -p {project}